-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable IO20 on ESP32 (IDFGH-5140) #6918
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some newer ESP32 variants (like ESP32-PICO-V3 and ESP32-PICO-MINI-02) do implement this pin and it can be used as a normal GPIO. This patch enables it unconditionally, leaving the responsability of using it correctly to the developer. Fixes espressif#6016 Fixes espressif#6837
If you'd prefer this to be gated behind an option, I can amend the patch to do so. Please, let me know. Thanks! |
github-actions
bot
changed the title
Enable IO20 on ESP32
Enable IO20 on ESP32 (IDFGH-5140)
Apr 21, 2021
sfowlr
reviewed
Jul 18, 2021
@@ -116,7 +116,7 @@ | |||
// control pullup/down/capability, independent with RTC registers. | |||
|
|||
// 0~39 except from 20, 24, 28~31 are valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May want to update the comment here to reflect the change made below -
Suggested change
// 0~39 except from 20, 24, 28~31 are valid | |
// 0~39 except for 24, 28~31 are valid |
Hello, any advances in this? |
espressif-bot
added
Resolution: NA
Issue resolution is unavailable
Status: Done
Issue is done internally
Resolution: Done
Issue is done internally
and removed
Status: Opened
Issue is new
Resolution: NA
Issue resolution is unavailable
labels
Aug 25, 2021
espressif-bot
pushed a commit
that referenced
this pull request
Oct 12, 2021
espressif-bot
pushed a commit
that referenced
this pull request
Dec 4, 2021
espressif-bot
pushed a commit
that referenced
this pull request
Dec 4, 2021
espressif-bot
pushed a commit
that referenced
this pull request
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some newer ESP32 variants (like ESP32-PICO-V3 and ESP32-PICO-MINI-02)
do implement this pin and it can be used as a normal GPIO.
This patch enables it unconditionally, leaving the responsability
of using it correctly to the developer.
Fixes #6016
Fixes #6837